Vladimir Sementsov-Ogievskiy <[email protected]> writes: > This option for tap and vhost-user netdevs doesn't make sense > since long ago (10 years!), starting from commits: > > 1e7398a140f7a6 ("vhost: enable vhost without without MSI-X") > 24f938a682d934 ("vhost user:support vhost user nic for non msi guests") > > Prior these commits, to enable kernel vhost-net, or vhost-user-net for > some specific kind of guests (that don't have MSI-X support), you should > have set vhostforce=on. > > Now guest type doesn't matter, all guests are equal for these > options logic. > > For tap the current logic is: > vhost=on / vhost=off : vhostforce ignored, doesn't make sense > vhost unset : vhostforce counts, enabling vhost > > So you may enable vhost for tap several ways: > - vhost=on > - vhostforce=on > - vhost=on + vhostforce=on > - and even vhost=on + vhostforce=off > > - they are all equal. > > For vhost-user we simply ignore the vhostforce option at all in the > code. > > Let's finally deprecate the extra options. > > Also, fix @vhostforce documentation everywhere to show the real picture, > and update vhost-user test to not use deprecated option. > > While updating command line options, drop "experimental" word from > "experimental in kernel accelerator". vhost-net is in production for > years. > > Signed-off-by: Vladimir Sementsov-Ogievskiy <[email protected]>
Reviewed-by: Markus Armbruster <[email protected]>
