Hi On Thu, Oct 30, 2025 at 6:48 PM Daniel P. Berrangé <[email protected]> wrote:
> Readability of the credential files is what matters for our usage, > so access() is more appropriate than stat(). > > Signed-off-by: Daniel P. Berrangé <[email protected]> > Reviewed-by: Marc-André Lureau <[email protected]> > --- > crypto/tlscreds.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/crypto/tlscreds.c b/crypto/tlscreds.c > index 9e59594d67..208a7e6d8f 100644 > --- a/crypto/tlscreds.c > +++ b/crypto/tlscreds.c > @@ -100,7 +100,6 @@ qcrypto_tls_creds_get_path(QCryptoTLSCreds *creds, > char **cred, > Error **errp) > { > - struct stat sb; > int ret = -1; > > if (!creds->dir) { > @@ -114,7 +113,7 @@ qcrypto_tls_creds_get_path(QCryptoTLSCreds *creds, > > *cred = g_strdup_printf("%s/%s", creds->dir, filename); > > - if (stat(*cred, &sb) < 0) { > + if (access(*cred, R_OK) < 0) { > if (errno == ENOENT && !required) { > ret = 0; > } else { > -- > 2.51.1 > >
