On Sat, 1 Nov 2025 at 13:48, Bernhard Beschow <[email protected]> wrote: > > > > Am 1. November 2025 13:13:26 UTC schrieb Peter Maydell > <[email protected]>: > >On Sat, 1 Nov 2025 at 13:04, Bernhard Beschow <[email protected]> wrote: > >> > >> Now that MSYS2 provides an implementation of the function it clashes with > >> QEMU's, resulting in a compilation error. Remove it since it doesn't seem > >> to be used anyway. > > > >The comment says it's used by _bstr_t, which presumably > >is in some Windows header or library that we're linking against. > >Our code seems to use _bstr_t a lot. Is this function definitely > >not required, or should we have something so we provide it only > >when MSYS2 does not? > > I just grepped the code and it doesn't return any users. And searching > the git history it never did.
The comment suggests that the user would be in the MS headers we're including or the library we're linking against, not in our own code, though, so grep wouldn't find it. -- PMM
