Jamin, On 11/3/25 10:27, Jamin Lin wrote:
v1: 1. Split each Aspeed machine into its own source file for better readability and maintainability: - Quanta-Q71L - Supermicro X11 - Palmetto - Bletchley - fby35 BMC - Facebook Fuji - QCOM Firework - QCOM DC-SCM V1 - GB200NVL - Rainier - Catalina - AST2600 EVB - AST2700 EVB - AST1030 EVB 2. Make aspeed_machine_ast2600_class_emmc_init() a shared API for eMMC boot setup. 3. Promote connect_serial_hds_to_uarts() to a public machine API for reuse across platforms.v2: 1. Restore ASPEED_RAM_SIZE() macro v3: 1. Merged AST2500 SoC machine changes into this patch series. Split each AST2500 machine into its own source file: - FP5280G2 - G220A - Tiogapass - YosemiteV2 - Witherspoon - Sonorapass - Romulus - Supermicro X11SPI - AST2500 EVB 2. Renamed common API functions with the aspeed_ prefix for consistency. 3. Added detailed descriptions for the common API functions. Jamin Lin (30): hw/arm/aspeed: Move AspeedMachineState definition to common header for reuse hw/arm/aspeed: Make aspeed_machine_class_init_cpus_defaults() globally accessible hw/arm/aspeed: Export and rename create_pca9552() for reuse hw/arm/aspeed: Rename and export create_pca9554() as aspeed_create_pca9554() hw/arm/aspeed: Split FP5280G2 machine into a separate source file for maintenance hw/arm/aspeed: Split G220A machine into a separate source file for better maintenance hw/arm/aspeed: Split Tiogapass machine into a separate source file for cleanup hw/arm/aspeed: Split YosemiteV2 machine into a separate source file for maintainability hw/arm/aspeed: Split Witherspoon machine into a separate source file for maintainability hw/arm/aspeed: Split Sonorapass machine into a separate source file for maintainability hw/arm/aspeed: Split Romulus machine into a separate source file for maintainability hw/arm/aspeed: Split Supermicro X11SPI machine into a separate file for maintainability hw/arm/aspeed: Split AST2500 EVB machine into a separate source file for maintainability hw/arm/aspeed: Split Quanta-Q71L machine into a separate source file for maintainability hw/arm/aspeed: Split Supermicro X11 machine into a separate source file for maintainability hw/arm/aspeed: Split Palmetto machine into a separate source file for maintainability hw/arm/aspeed: Move ASPEED_RAM_SIZE() macro to common header for reuse hw/arm/aspeed: Split Bletchley machine into a separate source file for maintainability hw/arm/aspeed: Split FBY35 BMC machine into a separate source file for maintainability hw/arm/aspeed: Split Fuji machine into a separate source file for maintainability hw/arm/aspeed: Split QCOM Firework machine into a separate source file for maintainability hw/arm/aspeed: Split QCOM DC-SCM V1 machine into a separate source file for maintainability hw/arm/aspeed: Make aspeed_machine_ast2600_class_emmc_init() a common API for eMMC boot setup hw/arm/aspeed: Split GB200NVL machine into a separate source file for maintainability hw/arm/aspeed: Split Rainier machine into a separate source file for maintainability hw/arm/aspeed: Split Catalina machine into a separate source file for maintainability hw/arm/aspeed: Split AST2600 EVB machine into a separate source file for maintainability hw/arm/aspeed: Split AST2700 EVB machine into a separate source file for maintainability hw/arm/aspeed: Rename and export connect_serial_hds_to_uarts() as aspeed_connect_serial_hds_to_uarts() hw/arm/aspeed: Split AST1030 EVB machine into a separate source file for maintainability hw/arm/aspeed_eeprom.h | 32 - include/hw/arm/aspeed.h | 79 + hw/arm/aspeed.c | 1678 +-------------------- hw/arm/aspeed_ast10x0_evb.c | 109 ++ hw/arm/aspeed_ast2400_palmetto.c | 81 + hw/arm/aspeed_ast2400_quanta-q71l.c | 87 ++ hw/arm/aspeed_ast2400_supermicrox11.c | 82 + hw/arm/aspeed_ast2500_evb.c | 68 + hw/arm/aspeed_ast2500_fp5280g2.c | 89 ++ hw/arm/aspeed_ast2500_g220a.c | 93 ++ hw/arm/aspeed_ast2500_romulus.c | 63 + hw/arm/aspeed_ast2500_sonorapass.c | 103 ++ hw/arm/aspeed_ast2500_supermicro-x11spi.c | 78 + hw/arm/aspeed_ast2500_tiogapass.c | 91 ++ hw/arm/aspeed_ast2500_witherspoon.c | 113 ++ hw/arm/aspeed_ast2500_yosemitev2.c | 92 ++ hw/arm/aspeed_ast2600_bletchley.c | 98 ++ hw/arm/aspeed_ast2600_catalina.c | 226 +++ hw/arm/aspeed_ast2600_evb.c | 66 + hw/arm/aspeed_ast2600_fby35.c | 179 +++ hw/arm/aspeed_ast2600_fuji.c | 141 ++ hw/arm/aspeed_ast2600_gb200nvl.c | 112 ++ hw/arm/aspeed_ast2600_qcom-dc-scm-v1.c | 56 + hw/arm/aspeed_ast2600_qcom-firework.c | 92 ++ hw/arm/aspeed_ast2600_rainier.c | 199 +++ hw/arm/aspeed_ast27x0_evb.c | 89 ++ hw/arm/aspeed_eeprom.c | 192 --- hw/arm/meson.build | 24 +- 28 files changed, 2515 insertions(+), 1897 deletions(-) delete mode 100644 hw/arm/aspeed_eeprom.h create mode 100644 hw/arm/aspeed_ast10x0_evb.c create mode 100644 hw/arm/aspeed_ast2400_palmetto.c create mode 100644 hw/arm/aspeed_ast2400_quanta-q71l.c create mode 100644 hw/arm/aspeed_ast2400_supermicrox11.c create mode 100644 hw/arm/aspeed_ast2500_evb.c create mode 100644 hw/arm/aspeed_ast2500_fp5280g2.c create mode 100644 hw/arm/aspeed_ast2500_g220a.c create mode 100644 hw/arm/aspeed_ast2500_romulus.c create mode 100644 hw/arm/aspeed_ast2500_sonorapass.c create mode 100644 hw/arm/aspeed_ast2500_supermicro-x11spi.c create mode 100644 hw/arm/aspeed_ast2500_tiogapass.c create mode 100644 hw/arm/aspeed_ast2500_witherspoon.c create mode 100644 hw/arm/aspeed_ast2500_yosemitev2.c create mode 100644 hw/arm/aspeed_ast2600_bletchley.c create mode 100644 hw/arm/aspeed_ast2600_catalina.c create mode 100644 hw/arm/aspeed_ast2600_evb.c create mode 100644 hw/arm/aspeed_ast2600_fby35.c create mode 100644 hw/arm/aspeed_ast2600_fuji.c create mode 100644 hw/arm/aspeed_ast2600_gb200nvl.c create mode 100644 hw/arm/aspeed_ast2600_qcom-dc-scm-v1.c create mode 100644 hw/arm/aspeed_ast2600_qcom-firework.c create mode 100644 hw/arm/aspeed_ast2600_rainier.c create mode 100644 hw/arm/aspeed_ast27x0_evb.c delete mode 100644 hw/arm/aspeed_eeprom.c
It looks good. Could you please maintain : Copyright 2016 IBM Corp. in the new files since the code is copied from aspeed.c. Thanks, C.
