On Tue, Nov 04, 2025 at 04:26:56AM -0800, Shameer Kolothum wrote: > > > +static bool > > > +smmuv3_accel_dev_install_nested_ste(SMMUv3AccelDevice *accel_dev, > > > + uint32_t data_type, uint32_t > > > data_len, > > > + void *data, Error **errp) > > the name is very close to the caller function, ie. > > smmuv3_accel_install_nested_ste which also takes a sdev. > > I would rename to smmuv3_accel_install_hwpt() or something alike > > This one is going to change a bit based on Nicolin's feedback on taking > care of SMMUEN/GBPA values. > > Probably smmuv3_accel_attach_nested_hwpt() suits better considering > that’s what it finally ends up doing.
Eric is right, because the current version passes in hwpt data for allocation. Yet, my new version passes in STE, so naming could keep "ste" IMHO. Thanks Nicolin
