On 11/5/25 16:24, Magnus Kulke wrote:
On Mon, Nov 03, 2025 at 10:43:36PM +0100, Cédric Le Goater wrote:
Hi,

On 10/9/25 09:50, Paolo Bonzini wrote:
From: Magnus Kulke <[email protected]>

Rename APIC helper functions to use an accel_* prefix instead of kvm_*
to support use by accelerators other than KVM. This is a preparatory
step for integrating MSHV support with common APIC logic.

Signed-off-by: Magnus Kulke <[email protected]>
Link: 
https://lore.kernel.org/r/[email protected]
[Remove dead definition of mshv_msi_via_irqfd_enabled. - Paolo]
Signed-off-by: Paolo Bonzini <[email protected]>
---
   include/system/accel-irq.h |  37 +++++++++++++
   include/system/mshv.h      |  17 ++++++
   accel/accel-irq.c          | 106 +++++++++++++++++++++++++++++++++++++
   hw/intc/ioapic.c           |  20 ++++---
   hw/virtio/virtio-pci.c     |  21 ++++----
   accel/meson.build          |   2 +-
   6 files changed, 185 insertions(+), 18 deletions(-)
   create mode 100644 include/system/accel-irq.h
   create mode 100644 accel/accel-irq.c

This change seems to introduce a regression with interrupt remapping
when running a VM configured with an intel-iommu device and an assigned
PCI VF. At boot, Linux complains with :


Thank you for reporting, Cédric. From glancing over it, it looks like a
typo: we check for `ACCEL_KERNEL_GSI_IRQFD_POSSIBLE` instead of
`ACCEL_GSI_IRQFD_POSSIBLE` in ioapic.c. The former doesn't seem to be
defined anywhere.

Can you verify if changing that fixes the issue for you?

s/ACCEL_KERNEL_GSI_IRQFD_POSSIBLE/ACCEL_GSI_IRQFD_POSSIBLE/g

Oh I should have spotted that. Kernel does not hang anymore and messages
are gone. Sending a patch.

Thanks,

C.




Reply via email to