On Tue, Nov 11, 2025 at 05:17:09PM +0000, Alex Bennée wrote: > We will need the latest version to add coreutils in the next commit. > As libvirt has updated the handling of ENV variables this brings a > little bit of churn to the docker images.
FWIW, the dockerfile ENV syntax without the '=' has been deprecated, so this change was adapting to current supported syntax: https://github.com/docker/cli/pull/2743 https://github.com/docker/cli/pull/2741 If we happen to have any hand-written dockerfiles that use the old ENV syntax without '=' we should look to convert them to use '=' too, but that can be a separate commit, if we need it. > Signed-off-by: Alex Bennée <[email protected]> > --- > tests/docker/dockerfiles/alpine.docker | 10 +++++----- > tests/docker/dockerfiles/centos9.docker | 10 +++++----- > .../dockerfiles/debian-amd64-cross.docker | 16 ++++++++-------- > .../dockerfiles/debian-arm64-cross.docker | 16 ++++++++-------- > .../dockerfiles/debian-armhf-cross.docker | 16 ++++++++-------- > .../dockerfiles/debian-i686-cross.docker | 16 ++++++++-------- > .../dockerfiles/debian-mips64el-cross.docker | 16 ++++++++-------- > .../dockerfiles/debian-mipsel-cross.docker | 16 ++++++++-------- > .../dockerfiles/debian-ppc64el-cross.docker | 16 ++++++++-------- > .../dockerfiles/debian-riscv64-cross.docker | 19 ++++++++----------- > .../dockerfiles/debian-s390x-cross.docker | 16 ++++++++-------- > tests/docker/dockerfiles/debian.docker | 10 +++++----- > .../dockerfiles/fedora-rust-nightly.docker | 10 +++++----- > .../dockerfiles/fedora-win64-cross.docker | 14 +++++++------- > tests/docker/dockerfiles/fedora.docker | 10 +++++----- > tests/docker/dockerfiles/opensuse-leap.docker | 10 +++++----- > tests/docker/dockerfiles/ubuntu2204.docker | 10 +++++----- > tests/lcitool/libvirt-ci | 2 +- > 18 files changed, 115 insertions(+), 118 deletions(-) Reviewed-by: Daniel P. Berrangé <[email protected]> With regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
