On Wed, Nov 12, 2025 at 2:21 AM Philippe Mathieu-Daudé <[email protected]> wrote:
> Hi Edgar, > > On 11/11/25 22:28, Edgar E. Iglesias wrote: > > On Tue, Oct 21, 2025 at 2:59 PM Philippe Mathieu-Daudé > > <[email protected] <mailto:[email protected]>> wrote: > > > > Implement the TargetInfo structure for qemu-system-arm > > and qemu-system-aarch64 binaries. > > > > Signed-off-by: Philippe Mathieu-Daudé <[email protected] > > <mailto:[email protected]>> > > Reviewed-by: Pierrick Bouvier <[email protected] > > <mailto:[email protected]>> > > Reviewed-by: Richard Henderson <[email protected] > > <mailto:[email protected]>> > > > > > > > > Hi Phil! > > > > Trying to run xenpvh guests with latest QEMU but running into trouble, > > the xenpvh does get built into qemu-system-aarch64 any more. > > Bisecting pointed me to this patch. > > > > To reproduce --enable-xen, and see if xenpvh shows up in -M \? or not. > > > > Any ideas? > > Oops, sorry for that :/ > > I suppose I missed the following in commit 38c5ab40031 ("hw/arm: Filter > machine types for qemu-system-arm/aarch64 binaries"): > > -- >8 -- > diff --git a/hw/arm/xen-pvh.c b/hw/arm/xen-pvh.c > index 1a9eeb01c8e..86a02966161 100644 > --- a/hw/arm/xen-pvh.c > +++ b/hw/arm/xen-pvh.c > @@ -12,2 +12,3 @@ > #include "hw/xen/xen-pvh-common.h" > +#include "hw/arm/machines-qom.h" > > @@ -97,2 +98,3 @@ static const TypeInfo xen_arm_machine_type = { > .instance_init = xen_arm_instance_init, > + .interfaces = arm_aarch64_machine_interfaces, > }; > --- > > I don't have a handy Aarch64 machine with Xen anymore, I'll see > tomorrow if I can get access to one. Do you mind testing this hunk > meanwhile? > Thanks Phil! Yes, that fixes it! Cheers, Edgar > > Thanks, > > Phil. >
