On Thu, Nov 13, 2025 at 09:18:19AM +0000, Daniel P. Berrangé wrote: > On Thu, Nov 13, 2025 at 09:05:25AM +0100, Thomas Huth wrote: > > From: Thomas Huth <[email protected]> > > > > Running "./check -ssh 207" fails for me with lots of lines like this > > in the output: > > > > +base64: invalid input > > > > While looking closer at it, I noticed that the grep -v "\\^#" command > > in this test is not working as expected - it is likely meant to filter > > out the comment lines that are starting with a "#", but at least my > > version of grep (GNU grep 3.11) does not work with the backslashes here. > > There does not seem to be a compelling reason for these backslashes, > > so let's simply drop them to fix this issue. > > > > Signed-off-by: Thomas Huth <[email protected]> > > --- > > tests/qemu-iotests/207 | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > Reviewed-by: Daniel P. Berrangé <[email protected]>
Not quite NBD material, but since it touches iotests and I was preparing a pull request that benefitted from a cleaner run, I went ahead and queued it through my tree. -- Eric Blake, Principal Software Engineer Red Hat, Inc. Virtualization: qemu.org | libguestfs.org
