Apart from style issues, Pylint can help to detect real bugs in Python
code, so this patch series first introduces a pylintrc file that is
suitable for the code that we have in tests/functional, then cleans
up all current issues and finally introduces a test that checks the
files in the target folders automatically during each run (I still
need to ponder on where to best check for the generic code, but I had
a discussion with John S about pylint yesterday, so I wanted to get this
series on the list for discussion ... the generic part can also be added
later).
Note that patch 2 - 4 have already been reviewed, I just included them
for completeness here so that the linters check does not fail if anybody
wants to try it.
Thomas Huth (15):
tests/functional: Add a pylintrc file
tests/functional/riscv64/test_sifive_u: Remove unused import statement
tests/functional/arm/test_aspeed_ast2600_buildroot: Fix pylint
warnings
tests/functional/x86_64/test_virtio_gpu: Fix various issues reported
by pylint
tests/functional/mips/test_malta: Silence warnings reported by pylint
tests/functional/ppc64/test_hv: Silence warnings reported by pylint
tests/functional/x86_64/test_reverse_debug: Silence pylint warning
tests/functional/x86_64/test_memlock: Silence pylint warnings
tests/functional/ppc/test_amiga: Fix issues reported by pylint and
flake8
tests/functional/ppc/test_ppe42: Fix style issues reported by pylint
tests/functional/aarch64/test_virt_gpu: Fix style issues
tests/functional/aarch64/test_reverse_debug: Fix issues reported by
pylint
tests/functional/aarch64/test_smmu: Silence warning from pylint
tests/functional/aarch64/test_rme_sbsaref: Silence issues reported by
pylint
tests/functional: Add a generic test that checks the files with pylint
MAINTAINERS | 1 +
.../functional/aarch64/test_reverse_debug.py | 4 +-
tests/functional/aarch64/test_rme_sbsaref.py | 3 +-
tests/functional/aarch64/test_smmu.py | 1 +
tests/functional/aarch64/test_virt_gpu.py | 20 ++---
.../arm/test_aspeed_ast2600_buildroot.py | 21 ++---
tests/functional/generic/meson.build | 1 +
tests/functional/generic/test_linters.py | 41 ++++++++++
tests/functional/mips/test_malta.py | 8 +-
tests/functional/ppc/test_amiga.py | 6 +-
tests/functional/ppc/test_ppe42.py | 14 ++--
tests/functional/ppc64/test_hv.py | 10 +--
tests/functional/pylintrc | 80 +++++++++++++++++++
tests/functional/riscv64/test_sifive_u.py | 1 -
tests/functional/x86_64/test_memlock.py | 6 +-
tests/functional/x86_64/test_reverse_debug.py | 2 +-
tests/functional/x86_64/test_virtio_gpu.py | 56 ++++++-------
17 files changed, 199 insertions(+), 76 deletions(-)
create mode 100755 tests/functional/generic/test_linters.py
create mode 100644 tests/functional/pylintrc
--
2.51.1
