Cc: trimmed Markus Armbruster <[email protected]> writes:
> "Dr. David Alan Gilbert" <[email protected]> writes: > >> * Markus Armbruster ([email protected]) wrote: >>> Use error_setg_errno() instead of passing the value of strerror() or >>> g_strerror() to error_setg(). >>> >>> The separator between the error message proper and the value of >>> strerror() changes from " : ", "", " - ", "- " to ": " in places. >>> >>> Signed-off-by: Markus Armbruster <[email protected]> >> >>> @@ -792,9 +792,9 @@ static void vfu_object_init_ctx(VfuObject *o, Error >>> **errp) >>> VFU_REGION_FLAG_RW | VFU_REGION_FLAG_ALWAYS_CB, >>> NULL, 0, -1, 0); >>> if (ret < 0) { >>> - error_setg(errp, >>> - "vfu: Failed to setup config space handlers for %s- %s", >>> - o->device, strerror(errno)); >>> + error_setg_errno(errp, >>> + "vfu: Failed to setup config space handlers for >>> %s", >>> + o->device); >> >> missing errno. > > Yes. > >>> goto fail; >>> } >>> >>> @@ -822,8 +822,8 @@ static void vfu_object_init_ctx(VfuObject *o, Error >>> **errp) >>> >>> ret = vfu_realize_ctx(o->vfu_ctx); >>> if (ret < 0) { >>> - error_setg(errp, "vfu: Failed to realize device %s- %s", >>> - o->device, strerror(errno)); >>> + error_setg_errno(errp, "vfu: Failed to realize device %s", >>> + o->device); >> >> missing errno. > > Yes. Another file my build tree doesn't compile anymore. Will fix, > thanks! > > [...] To include it in the build, I need to pass --enable-vfio-user-server to configure, then install the libaries configure asked for. Build then fails for me: FAILED: subprojects/libvfio-user/test/unit_tests.p/unit-tests.c.o cc -m64 -Isubprojects/libvfio-user/test/unit_tests.p -Isubprojects/libvfio-user/test -I../subprojects/libvfio-user/test -Isubprojects/libvfio-user/include -I../subprojects/libvfio-user/include -Isubprojects/libvfio-user/lib -I../subprojects/libvfio-user/lib -I/usr/include/json-c -fdiagnostics-color=auto -Wall -Winvalid-pch -Wextra -Werror -std=gnu99 -O2 -g -DSTAP_SDT_V2 -mcx16 -msse2 -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE -fno-strict-aliasing -fno-common -fwrapv -ftrivial-auto-var-init=zero -fzero-call-used-regs=used-gpr -fPIE -DUNIT_TEST -DWITH_TRAN_PIPE -D_GNU_SOURCE -Werror -DDEBUG -Wno-missing-field-initializers -Wmissing-declarations -Wwrite-strings -MD -MQ subprojects/libvfio-user/test/unit_tests.p/unit-tests.c.o -MF subprojects/libvfio-user/test/unit_tests.p/unit-tests.c.o.d -o subprojects/libvfio-user/test/unit_tests.p/unit-tests.c.o -c ../subprojects/libvfio-user/test/unit-tests.c ../subprojects/libvfio-user/test/unit-tests.c: In function ‘test_device_is_stopped_and_copying’: ../subprojects/libvfio-user/test/unit-tests.c:585:23: error: storing the address of local variable ‘migration’ in ‘vfu_ctx.migration’ [-Werror=dangling-pointer=] 585 | vfu_ctx.migration = &migration; | ~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~ ../subprojects/libvfio-user/test/unit-tests.c:584:22: note: ‘migration’ declared here 584 | struct migration migration; | ^~~~~~~~~ ../subprojects/libvfio-user/test/unit-tests.c:62:18: note: ‘vfu_ctx’ declared here 62 | static vfu_ctx_t vfu_ctx; | ^~~~~~~ cc1: all warnings being treated as errors and FAILED: subprojects/libvfio-user/lib/libvfio-user.so.0.0.1.p/libvfio-user.c.o cc -m64 -Isubprojects/libvfio-user/lib/libvfio-user.so.0.0.1.p -Isubprojects/libvfio-user/lib -I../subprojects/libvfio-user/lib -Isubprojects/libvfio-user/include -I../subprojects/libvfio-user/include -I/usr/include/json-c -fvisibility=hidden -fdiagnostics-color=auto -Wall -Winvalid-pch -Wextra -Werror -std=gnu99 -O2 -g -DSTAP_SDT_V2 -mcx16 -msse2 -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE -fno-strict-aliasing -fno-common -fwrapv -ftrivial-auto-var-init=zero -fzero-call-used-regs=used-gpr -fPIC -D_GNU_SOURCE -Werror -DDEBUG -Wno-missing-field-initializers -Wmissing-declarations -Wwrite-strings -MD -MQ subprojects/libvfio-user/lib/libvfio-user.so.0.0.1.p/libvfio-user.c.o -MF subprojects/libvfio-user/lib/libvfio-user.so.0.0.1.p/libvfio-user.c.o.d -o subprojects/libvfio-user/lib/libvfio-user.so.0.0.1.p/libvfio-user.c.o -c ../subprojects/libvfio-user/lib/libvfio-user.c ../subprojects/libvfio-user/lib/libvfio-user.c: In function ‘handle_device_get_region_io_fds’: ../subprojects/libvfio-user/lib/libvfio-user.c:617:38: error: ‘calloc’ sizes specified with ‘sizeof’ in the earlier argument and not in the later argument [-Werror=calloc-transposed-args] 617 | msg->out.fds = calloc(sizeof(int), max_sent_sub_regions); | ^~~ ../subprojects/libvfio-user/lib/libvfio-user.c:617:38: note: earlier argument should specify number of elements, later size of each element cc1: all warnings being treated as errors
