> -----Original Message-----
> From: Nicolin Chen <[email protected]>
> Sent: 21 November 2025 17:56
> To: Shameer Kolothum <[email protected]>
> Cc: [email protected]; [email protected];
> [email protected]; [email protected]; Jason Gunthorpe
> <[email protected]>; [email protected]; [email protected]; Nathan
> Chen <[email protected]>; Matt Ochs <[email protected]>;
> [email protected]; [email protected];
> [email protected]; [email protected];
> [email protected]; [email protected]; [email protected];
> Krishnakant Jaju <[email protected]>
> Subject: Re: [PATCH v6 17/33] hw/arm/smmuv3: Add support for providing a
> direct MSI doorbell GPA
>
> > > > + if (object_property_find(OBJECT(dev), "accel") &&
> > > > + object_property_get_bool(OBJECT(dev), "accel",
> > > > &error_abort)) {
> > >
> > > Do we need object_property_find()? A later patch seems to drop it.
> > > Perhaps we shouldn't add it in the first place?
> >
> > We need that at this stage as we haven't added the "accel" property yet
> > and that will cause "make check" tests to fail without that.
> >
> > We remove it once we introduce "accel" property later.
>
> Hmm, I assume object_property_get_bool() would return false when
> "accel" is not available yet? No?
It is the errp that will be set if there is no "accel" is available that will
fail the
tests. Another way to avoid object_property_find() is to pass NULL for errp in
object_property_get_bool(), but I think again when we introduce "accel" we have
change that into either errp/error_abort here.
I am not sure there is any other way to handle this.
Thanks,
Shameer
