2025-11-20T12:46:46-08:00, Drew Fustini <[email protected]>: > On Thu, Nov 20, 2025 at 05:07:03PM +0100, Radim Krčmář wrote: >> 2025-11-19T16:42:17-08:00, Drew Fustini <[email protected]>: >> > diff --git a/target/riscv/cpu.c b/target/riscv/cpu.c >> > @@ -216,6 +216,7 @@ const RISCVIsaExtData isa_edata_arr[] = { >> > ISA_EXT_DATA_ENTRY(ssdbltrp, PRIV_VERSION_1_13_0, ext_ssdbltrp), >> > ISA_EXT_DATA_ENTRY(ssnpm, PRIV_VERSION_1_13_0, ext_ssnpm), >> > ISA_EXT_DATA_ENTRY(sspm, PRIV_VERSION_1_13_0, ext_sspm), >> > + ISA_EXT_DATA_ENTRY(ssqosid, PRIV_VERSION_1_12_0, ext_ssqosid), >> >> Just out of curiosity, where does PRIV_VERSION_1_12_0 come from? > > Ssqosid was originally ratified as a separate document but it since was > add to the Privileged Architecture document [1]. However, the Supervisor > Level ISA was version 1.13 when Ssqosid was added, so I should change > the above to PRIV_VERSION_1_13_0.
I was mainly wondering if the PRIV_VERSION_* symbols have any meaning. I think PRIV_VERSION_1_13_0 refers to manual version 20241017 while the changelog has Ssqosid in 20241101... I guess there is no meaning, and PRIV_VERSION_1_12_0 would work just as well. :)
