On Tue, Nov 25, 2025 at 10:31:45AM +0100, Christian Speich wrote:
> On Mon, Nov 24, 2025 at 05:20:08AM +0100, Philippe Mathieu-Daudé wrote:
> > As a 'SD card vendor', QEMU chose to fill blocks with '1'
> > during erase operation. Update the DATA_STAT_AFTER_ERASE
> > SCR bit appropriately.
> >
> > Fixes: 818a5cdcfcf ("hw/sd: sd: Actually perform the erase operation")
> > Reported-by: Christian Speich <[email protected]>
> > Signed-off-by: Philippe Mathieu-Daudé <[email protected]>
> > ---
> > hw/sd/sd.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/hw/sd/sd.c b/hw/sd/sd.c
> > index 40a75a43ffb..d35537702b2 100644
> > --- a/hw/sd/sd.c
> > +++ b/hw/sd/sd.c
> > @@ -446,7 +446,7 @@ static void sd_set_scr(SDState *sd)
> > /* reserved for manufacturer usage */
> > sd->scr[4] = 0x00;
> > sd->scr[5] = 0x00;
> > - sd->scr[6] = 0x00;
> > + sd->scr[6] = 1 << 7; /* Data after an erase operation is 0xff */
>
> Although the rest of this function works on magic values, maybe it would be
> usefull to introduce a DATA_STAT_AFTER_ERASE define for this bit? This would
> make it easier to search for it in the spec (or other projects, google).
>
> Otherwise, lgtm. Reviewed-by: Christian Speich <[email protected]>
Sorry for the many mails, I'm not really familiar with SD/QEMU.
I've think this is wrong. Looking at the other fields set in sd_set_scr
I think scr[0] is the highest byte/bit not the lowest.
This should put DATA_STAT_AFTER_ERASE into scr[1] bit 7?
Greetings,
Christian
>
> Greetings,
> Christian
>
> > sd->scr[7] = 0x00;
> > }
> >
> > --
> > 2.51.0
> >
> >
>
