Re: [PATCH-for-11.0 06/12] target/sparc: Use little-endian variant of cpu_ld/st_data*()

[Philippe Mathieu-Daudé]

On 25/11/25 11:54, Philippe Mathieu-Daudé wrote:

We only build the SPARC targets using little endianness order,
therefore the cpu_ld/st_data*() definitions expand to the little
endian declarations. Use the explicit little-endian variants.

Wrong endianness in patch description, code change correct.

Mechanical change running:

   $ tgt=sparc; \
     end=be; \
     for op in data mmuidx_ra; do \
       for ac in uw sw l q; do \
         sed -i -e "s/cpu_ld${ac}_${op}/cpu_ld${ac}_${end}_${op}/" \
                   $(git grep -l cpu_ target/${tgt}/); \
       done;
       for ac in w l q; do \
         sed -i -e "s/cpu_st${ac}_${op}/cpu_st${ac}_${end}_${op}/" \
                   $(git grep -l cpu_ target/${tgt}/); \
       done;
     done

Signed-off-by: Philippe Mathieu-Daudé <phi...@linaro.org>
---
  target/sparc/ldst_helper.c | 6 +++---
  1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/target/sparc/ldst_helper.c b/target/sparc/ldst_helper.c
index 2c63eb9e036..bd0257d313a 100644
--- a/target/sparc/ldst_helper.c
+++ b/target/sparc/ldst_helper.c
@@ -1228,13 +1228,13 @@ uint64_t helper_ld_asi(CPUSPARCState *env, target_ulong 
addr,
              ret = cpu_ldub_data(env, addr);
              break;
          case 2:
-            ret = cpu_lduw_data(env, addr);
+            ret = cpu_lduw_be_data(env, addr);
              break;
          case 4:
-            ret = cpu_ldl_data(env, addr);
+            ret = cpu_ldl_be_data(env, addr);
              break;
          case 8:
-            ret = cpu_ldq_data(env, addr);
+            ret = cpu_ldq_be_data(env, addr);
              break;
          default:
              g_assert_not_reached();