Use fw_cfg_init_mem_nodma() instead of open-coding it.
Signed-off-by: Philippe Mathieu-Daudé <[email protected]>
---
hw/ppc/mac_newworld.c | 11 +----------
hw/ppc/mac_oldworld.c | 11 +----------
2 files changed, 2 insertions(+), 20 deletions(-)
diff --git a/hw/ppc/mac_newworld.c b/hw/ppc/mac_newworld.c
index 951de4bae4b..89cd1ed0311 100644
--- a/hw/ppc/mac_newworld.c
+++ b/hw/ppc/mac_newworld.c
@@ -453,16 +453,7 @@ static void ppc_core99_init(MachineState *machine)
pmac_format_nvram_partition(nvr, MACIO_NVRAM_SIZE);
/* No PCI init: the BIOS will do it */
- dev = qdev_new(TYPE_FW_CFG_MEM);
- fw_cfg = FW_CFG(dev);
- qdev_prop_set_uint32(dev, "data_width", 1);
- qdev_prop_set_bit(dev, "dma_enabled", false);
- object_property_add_child(OBJECT(machine), TYPE_FW_CFG, OBJECT(fw_cfg));
- s = SYS_BUS_DEVICE(dev);
- sysbus_realize_and_unref(s, &error_fatal);
- sysbus_mmio_map(s, 0, CFG_ADDR);
- sysbus_mmio_map(s, 1, CFG_ADDR + 2);
-
+ fw_cfg = fw_cfg_init_mem_nodma(CFG_ADDR, CFG_ADDR + 2, 1);
fw_cfg_add_i16(fw_cfg, FW_CFG_NB_CPUS, (uint16_t)machine->smp.cpus);
fw_cfg_add_i16(fw_cfg, FW_CFG_MAX_CPUS, (uint16_t)machine->smp.max_cpus);
fw_cfg_add_i64(fw_cfg, FW_CFG_RAM_SIZE, (uint64_t)machine->ram_size);
diff --git a/hw/ppc/mac_oldworld.c b/hw/ppc/mac_oldworld.c
index cd2bb46442f..25fb8ed070d 100644
--- a/hw/ppc/mac_oldworld.c
+++ b/hw/ppc/mac_oldworld.c
@@ -294,16 +294,7 @@ static void ppc_heathrow_init(MachineState *machine)
/* No PCI init: the BIOS will do it */
- dev = qdev_new(TYPE_FW_CFG_MEM);
- fw_cfg = FW_CFG(dev);
- qdev_prop_set_uint32(dev, "data_width", 1);
- qdev_prop_set_bit(dev, "dma_enabled", false);
- object_property_add_child(OBJECT(machine), TYPE_FW_CFG, OBJECT(fw_cfg));
- s = SYS_BUS_DEVICE(dev);
- sysbus_realize_and_unref(s, &error_fatal);
- sysbus_mmio_map(s, 0, CFG_ADDR);
- sysbus_mmio_map(s, 1, CFG_ADDR + 2);
-
+ fw_cfg = fw_cfg_init_mem_nodma(CFG_ADDR, CFG_ADDR + 2, 1);
fw_cfg_add_i16(fw_cfg, FW_CFG_NB_CPUS, (uint16_t)machine->smp.cpus);
fw_cfg_add_i16(fw_cfg, FW_CFG_MAX_CPUS, (uint16_t)machine->smp.max_cpus);
fw_cfg_add_i64(fw_cfg, FW_CFG_RAM_SIZE, (uint64_t)machine->ram_size);
--
2.51.0