>-----Original Message----- >From: Eric Auger <[email protected]> >>>> diff --git a/hw/i386/meson.build b/hw/i386/meson.build >>>> index 436b3ce52d..63ae57baa5 100644 >>>> --- a/hw/i386/meson.build >>>> +++ b/hw/i386/meson.build >>>> @@ -21,6 +21,7 @@ i386_ss.add(when: 'CONFIG_Q35', if_true: >>> files('pc_q35.c')) >>>> i386_ss.add(when: 'CONFIG_VMMOUSE', if_true: files('vmmouse.c')) >>>> i386_ss.add(when: 'CONFIG_VMPORT', if_true: files('vmport.c')) >>>> i386_ss.add(when: 'CONFIG_VTD', if_true: files('intel_iommu.c')) >>>> +i386_ss.add(when: 'CONFIG_VTD_ACCEL', if_true: >>> files('intel_iommu_accel.c')) >>>> i386_ss.add(when: 'CONFIG_SGX', if_true: files('sgx-epc.c','sgx.c'), >>>> if_false: files('sgx-stub.c')) >>>> >>> wrt comments made by Cédric in >>> >https://lore.kernel.org/all/IA3PR11MB9136B13C0C48EF293D3B599D92FAA@ >>> IA3PR11MB9136.namprd11.prod.outlook.com/ >>> I see you kept the original approach. I have no strong opinion on that. >>> I let Cédric's comment if he strongly disagrees. >> Guess you mean adding '#include CONFIG_DEVICES'? >> I added it in hw/i386/intel_iommu_accel.h, see above. There is reference to >> CONFIG_VTD_ACCEL in intel_iommu_accel.h, I thought it's better to add it >> there instead of intel_iommu_accel.c > >No I rather meant Cédric's comment on extending HostIOMMUDeviceClass >instead of using iommufd directly Eric
I had digged Cédric's suggestion, currently IOMMUFD is the only fresh new accel related IOMMU backend. I feel hard to foresee what a new accel backend e.g, IOMMUFD_v2 will be like, what a common abstract to make between them, just like the big difference between legacy VFIO and IOMMUFD backend. I think we can add the abstract layer when IOMMUFD_v2 comes in the future, if Cédric agrees. Thanks Zhenzhong
