On Thu, 18 Dec 2025 21:31:20 +0300, Aleksandr Sergeev wrote:
>diff --git a/hw/misc/virt_pmu.c b/hw/misc/virt_pmu.c
>new file mode 100644
>index 0000000000..afba06de0e
>--- /dev/null
>+++ b/hw/misc/virt_pmu.c
>@@ -0,0 +1,142 @@
>+/*
>+ * RISC-V Virt machine PMU emulation.
>+ *
>+ * Copyright (c) 2025 Syntacore.
>+ *
>+ * This program is free software; you can redistribute it and/or modify it
>+ * under the terms and conditions of the GNU General Public License,
>+ * version 2 or later, as published by the Free Software Foundation.
>+ *
>+ * This program is distributed in the hope it will be useful, but WITHOUT
>+ * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
>+ * FITNESS FOR A PARTICULAR PURPOSE.  See the GNU General Public License for
>+ * more details.
>+ *
>+ * You should have received a copy of the GNU General Public License along 
>with
>+ * this program.  If not, see <http://www.gnu.org/licenses/>.
>+ */
>
The virt_pmu.c requires 'SPDX-License-Identifier: GPL-2.0-or-later'

...

>--- /dev/null
>+++ b/include/hw/misc/virt_pmu.h
>@@ -0,0 +1,91 @@
>+/*
>+ * RISC-V Virt machine PMU header file.
>+ * Copyright (C) 2025, Syntacore Ltd.
>+ *
>+ * This program is free software; you can redistribute it and/or
>+ * modify it under the terms of the GNU General Public License
>+ * as published by the Free Software Foundation; either version 2
>+ * of the License, or (at your option) any later version.
>+ *
>+ * This program is distributed in the hope that it will be useful,
>+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
>+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
>+ * GNU General Public License for more details.
>+ *
>+ * You should have received a copy of the GNU General Public License
>+ * along with this program; if not, write to the Free Software
>+ * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, 
>USA.
>+ * Also add information on how to contact you by electronic and paper mail.
>+ */
>+
The virt_pmu.h requires 'SPDX-License-Identifier: GPL-2.0-or-later'

>+#ifndef RISCV_VIRT_PMU_H
>+#define RISCV_VIRT_PMU_H
>+
...

Additionally, some code lines exceed 80 columns in length. It is recommended
to run `./scripts/checkpatch.pl` for further checks.

P.S. The file virt_pmu.c is a new addition. Does the MAINTAINERS file need
to be updated? :)

Thanks,
Chao

Reply via email to