Re: [PATCH v1 02/28] hw/accel: add a per-accelerator callback to change VM accelerator handle

[Gerd Hoffmann]

On Thu, Dec 18, 2025 at 05:26:42PM +0530, Ani Sinha wrote:
> 
> 
> > On 17 Dec 2025, at 7:44 PM, Gerd Hoffmann <kra...@redhat.com> wrote:
> > 
> >  Hi,
> > 
> >> +    /*
> >> +     * different accelerators implement how to close the old file handle 
> >> of
> >> +     * the accelerator descriptor and create a new one here. Resetting
> >> +     * file handle is necessary to create a new confidential VM context 
> >> post
> >> +     * VM reset.
> >> +     */
> >> +    if (current_machine->cgs && reason == SHUTDOWN_CAUSE_GUEST_RESET) {
> > 
> > So, the vmfd code is unly used in confidential VMs.  I think it makes
> > sense to offer some option to enable that for non-confidential VMs too.
> > Useful for development and also for testing this in qemu CI.
> 
> Good idea. However, for non-coco, there is really no reason to change
> vm file descriptor. So it has to be some config option only for
> testing and development.

Yes.

> I am open to suggestions as to what kind of
> option we can consider.

I think a machine option makes sense, so it can be accessed similar to ->cgs

take care,
  Gerd