On Wed, Jun 13, 2012 at 11:56:34AM +0100, Stefano Stabellini wrote: > On Tue, 12 Jun 2012, Michael S. Tsirkin wrote: > > On Tue, Jun 12, 2012 at 04:05:19PM +0100, Anthony PERARD wrote: > > > This reverts commit 94a09e2c846374a96719cda2b4e1312d8c4b08a7. > > > > > > This function is used by a later patch to parse the BDF of the device to > > > passthrough. > > > > > > Signed-off-by: Anthony PERARD <anthony.per...@citrix.com> > > > > You probably want to parse the host address? You don't want to copy the > > bugs in pci_parse_devaddr - write your own that has sane semantics > > for host. E.g. you need to support ARI etc. > > Aside from this minor comment, do you have any objections to this series?
Aside from this, there are minor pci core changes and these are all fine. I can't say I looked at the device itself too deeply but seems mergeable. > It has been outstanding for 9 months now, and the last few versions have > been without any major changes. > Considering that a new QEMU release cycle has just opened, I think that > now would be the perfect time to get the series in.
