On Wed, 4 Mar 2026, Christian Schoenebeck wrote:
On Wednesday, 4 March 2026 07:16:56 CET Akihiko Odaki wrote:
coreaudio had names that are not conforming to QEMU codding style.
coding
coreaudioVoiceOut also had some members that are prefixed with redundant
words like "output" or "audio".
Global names included "out" to tell they are specific to output devices,
but this rule was not completely enforced.
The frame size had three different names "frameSize", "bufferFrameSize",
and "frameCount".
Replace identifiers to fix these problems.
Signed-off-by: Akihiko Odaki <[email protected]>
Reviewed-by: Philippe Mathieu-Daudé <[email protected]>
---
audio/coreaudio.m | 188
+++++++++++++++++++++++++++--------------------------- 1 file changed, 95
insertions(+), 93 deletions(-)
diff --git a/audio/coreaudio.m b/audio/coreaudio.m
index bc9ab7477b68..736227eb2b7a 100644
--- a/audio/coreaudio.m
+++ b/audio/coreaudio.m
@@ -43,34 +43,34 @@
typedef struct coreaudioVoiceOut {
Leaving this lower case?
I think you can just drop it if you never refer to the type with struct
only as the CoreaudioVoiceOut typedef.
Regards,
BALATON Zoltan
