On 10/03/2026 12.47, Daniel P. Berrangé wrote:
When running functional tests directly there are some heuristics
to figure out where the build directory lives, along with the
possibility to override the logic by setting the QEMU_BUILD_DIR
env variable. This env var is set as part of the test env when
run via Meson but not when run directly.
A particular flaw with the currently logic is that it silently
uses the wrong location when the build directory is a sub-dir
under "./build", which is a common usage scenario for some devs.
With the recent introduction of the 'run' script, we now have
the MESON_BUILD_ROOT env variable set unconditionally, so we
can rely on that from the functional tests to get the correct
location in all scenarios.
Reported-by: Peter Maydell <[email protected]>
Signed-off-by: Daniel P. Berrangé <[email protected]>
---
tests/functional/meson.build | 2 +-
tests/functional/qemu_test/config.py | 4 ++--
2 files changed, 3 insertions(+), 3 deletions(-)
Reviewed-by: Thomas Huth <[email protected]>
