On 06/28/2012 02:21 PM, Jan Kiszka wrote:
On 2012-06-25 15:55, Igor Mammedov wrote:
v2:
- drop usage of prev_debug_excp_handler consistently in all users
- split from reset patches to avoid confusion of inter-dependency
Compile & Run tested:
target-i386: tcg and kvm mode
i386-linux-user: running of /bin/ls
Compile tested:
xtensa-softmmu && xtensaeb-softmmu
git tree for testing:
https://github.com/imammedo/qemu/tree/x86cpu_qom_tcg_v2
Igor Mammedov (4):
target-i386: drop usage of prev_debug_excp_handler
target-xtensa: drop usage of prev_debug_excp_handler
cleanup cpu_set_debug_excp_handler
target-i386: move tcg initialization into x86_cpu_initfn()
cpu-exec.c | 5 +----
exec-all.h | 2 +-
target-i386/cpu.c | 10 ++++++++++
target-i386/cpu.h | 1 +
target-i386/helper.c | 16 +---------------
target-xtensa/helper.c | 8 +-------
6 files changed, 15 insertions(+), 27 deletions(-)
Looks good to me.
Thanks for reviews guys.
Jan,
I'm still learning about review process rules. Does usually or in your case "Looks
good to me" implies Reviewed-By:... ?
And do I have to send pull request or ask somebody (whom?) to take patches in?
Jan
--
-----
Igor
