On 07/05/2012 06:51 AM, Orit Wasserman wrote: > In the outgoing migration check to see if the page is cached and > changed than send compressed page by using save_xbrle_page function. > In the incoming migration check to see if RAM_SAVE_FLAG_XBRLE is set > and decompress the page (by using load_xbrle function). > > Signed-off-by: Benoit Hudzia <benoit.hud...@sap.com> > Signed-off-by: Petter Svard <pett...@cs.umu.se> > Signed-off-by: Aidan Shribman <aidan.shrib...@sap.com> > Signed-off-by: Orit Wasserman <owass...@redhat.com> > ---
> +static int save_xbzrle_page(QEMUFile *f, uint8_t *current_data,
> + ram_addr_t current_addr, RAMBlock *block,
> + ram_addr_t offset, int cont, int stage)
> +{
> + int encoded_len = 0, bytes_sent = -1, ret = -1;
> + XBZRLEHeader hdr = {
> + .xh_len = 0,
> + .xh_flags = 0,
> + };
> + uint8_t *prev_cached_page;
> +
> + /* Stage 1 cache the page and exit.
> + Stage 2 check to see if page is cached , if not cache the page.
No space before comma in English comments:
s/ ,/,/
> + /* XBZRLE encoding (if there is no overflow) */
> + encoded_len = xbzrle_encode_buffer(prev_cached_page, current_data,
> + TARGET_PAGE_SIZE, XBZRLE.encoded_buf,
> + TARGET_PAGE_SIZE);
> + if (encoded_len == 0) {
> + DPRINTF("Unmodifed page skipping\n");
s/Unmodifed/Unmodified/
I mentioned in my v13 review changing this to:
s/Unmodifed page skipping/Skipping unmodified page/
it looks like you didn't pick up my v13 comments yet (and my fault for
not complaining at v14). As a result, I stopped reviewing here.
--
Eric Blake ebl...@redhat.com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
