On 10 July 2012 20:18, Blue Swirl <blauwir...@gmail.com> wrote: > On Mon, Jul 9, 2012 at 7:49 AM, Markus Armbruster <arm...@redhat.com> wrote: >> There is no consensus. I recognize the power of maintainers to force a >> change even without consensus. Use it wisely. > > I thought I refuted all concrete arguments except performance.
No, you made various claims that Markus and I at least disagreed with. (Conversely, we have made various claims that you disagree with -- this is what "no consensus" means...) > However, Avi kindly provided this part. One extra instruction, which isn't a load/store or branch? This is the worst kind of premature microoptimisation. If we're changing this it should be rooted in arguments about maintainability or similar, or alternatively if it's really a performance improvement I'm sure you can produce the benchmarks that demonstrate that :-) [Plus the extract/deposit ops aren't doing array accesses!] -- PMM