On 7/8/2026 1:13 AM, Daniel P. Berrangé wrote: > On Tue, Jul 07, 2026 at 02:46:52PM -0700, Pierrick Bouvier wrote: >> Using a list of string is not convenient, as users need to escape it >> manually and handle end of lines. By using a raw string literal, >> what you see is what you get. >> >> Signed-off-by: Pierrick Bouvier <[email protected]> >> --- >> tests/lcitool/refresh | 209 +++++++++++++++++++++--------------------- >> 1 file changed, 105 insertions(+), 104 deletions(-) > > Does what it says on the tin so.... > > Reviewed-by: Daniel P. Berrangé <[email protected]> > > ...but given the size of the trailer we have inline, I wonder if we > would be better off just having that trailer in a plain text file > alongside the refresh script, such that 'refresh' just auto-appends > any <foo>.trailer file contents to any docker file it emits called > "<foo>". >
IMHO a simple raw string literal in an existing script is enough, it's perfectly readable and maintainable this way. Adding yet another file means that you need to look in another place, which is already complex enough between the dockerfiles, lcitool itself, and refresh script. > With regards, > Daniel
