On Tue, Jul 24, 2012 at 9:26 AM, Markus Armbruster <arm...@redhat.com> wrote: > Peter Maydell <peter.mayd...@linaro.org> writes: > >> On 23 July 2012 18:33, Blue Swirl <blauwir...@gmail.com> wrote: >>> I'm getting a strong feeling that it's a bad idea to reuse any Linux >>> kernel sources since they are seen as divine and untouchable, unlike >>> for example BSD queue macros. > > Reusing good code that solves the problem at hand can be a bad idea if > you can't resist the temptation to tinker with it, yet can't be bothered > to upstream your improvements. Then you might as well build your own > bikeshed from scratch :)
There's nothing wrong in tinkering with reused good code. As I explained, there's little point to upstream these changes, so 'not bothering' is false accusation. > >> We should also try to avoid deviations in our queue macros, > > Agree. Avoiding "deviations" can be secondary to many other needs. > >> and I think we do (eg commit 6095aa8 added functionality by >> moving us closer into sync with the BSD macros rather than >> by reinventing the wheel which was IIRC what the initial pre-code-review >> patch did).
