On Tue, Jul 31, 2012 at 5:51 PM, Dong Xu Wang <wdon...@linux.vnet.ibm.com> wrote: > add-cow will let raw file support snapshot_blkdev indirectly. > > Signed-off-by: Dong Xu Wang <wdon...@linux.vnet.ibm.com> > --- > blockdev.c | 45 +++++++++++++++++++++++++++++++++++++-------- > docs/live-block-ops.txt | 11 ++++++++++- > 2 files changed, 47 insertions(+), 9 deletions(-)
This patch would need to update qapi-schema.json and qmp-commands.hx to make use of the new arguments. I don't think QEMU compiles cleanly after this patch. It's important to keep the build clean after every patch so that git-bisect(1) can be used (if you hit a broken build during a bisect it makes things harder). However, I think the QMP/HMP changes should not be included in this series unless you are sure the interface is stable. When you convert QEMUOptionsParameter will transaction or snapshot-blkdev-sync change? If so, please only send the add-cow image format and leave the QMP/HMP changes until you have the QemuOpts solution. Stefan
