Re: [PATCH 1/5] target/hexagon: Convert to translate_for_debug

[Brian Cain]

On 10/22/2026 7:58 AM, Peter Maydell wrote:

Convert hexagon to providing the translate_for_debug method rather
than the deprecated get_phys_addr_debug method.

Signed-off-by: Peter Maydell <peter.mayd...@linaro.org>
---

Reviewed-by: Brian Cain <brian.c...@oss.qualcomm.com>

  target/hexagon/cpu.c | 15 +++++++++++----
  1 file changed, 11 insertions(+), 4 deletions(-)

diff --git a/target/hexagon/cpu.c b/target/hexagon/cpu.c
index f20d6de6f63..5e99e84b075 100644
--- a/target/hexagon/cpu.c
+++ b/target/hexagon/cpu.c
@@ -612,7 +612,8 @@ static void find_qemu_subpage(vaddr *addr, hwaddr *phys, 
uint64_t page_size)
      *phys += offset;
  }

-static hwaddr hexagon_cpu_get_phys_addr_debug(CPUState *cs, vaddr addr)

+static bool hexagon_cpu_translate_for_debug(CPUState *cs, vaddr addr,
+                                            TranslateForDebugResult *result)
  {
      CPUHexagonState *env = cpu_env(cs);
      hwaddr phys_addr;
@@ -626,10 +627,16 @@ static hwaddr hexagon_cpu_get_phys_addr_debug(CPUState 
*cs, vaddr addr)
          vaddr page_offset = addr & (TARGET_PAGE_SIZE - 1);
          find_qemu_subpage(&addr, &phys_addr, page_size);
          phys_addr += hexagon_cpu_mmu_enabled(env) ? page_offset : 0;
-        return phys_addr;
+
+        *result = (TranslateForDebugResult) {
+            .physaddr = phys_addr,
+            .lg_page_size = TARGET_PAGE_BITS,
+            .attrs.debug = 1,
+        };
+        return true;
      }

- return -1;

+    return false;
  }

@@ -755,7 +762,7 @@ static bool hexagon_tlb_fill(CPUState *cs, vaddr address, int size, static const struct SysemuCPUOps hexagon_sysemu_ops = {

      .has_work = hexagon_cpu_has_work,
-    .get_phys_addr_debug = hexagon_cpu_get_phys_addr_debug,
+    .translate_for_debug = hexagon_cpu_translate_for_debug,
  };

static bool hexagon_cpu_exec_interrupt(CPUState *cs, int interrupt_request)