On 10/19/2026 2:20 PM, Pierrick Bouvier wrote: > When linking multiple targets together, we usually have conflicts with helper > names. So far, it was solved using ad-hoc renaming, but multiple people > pointed it > would be better to have a general mechanism for it, so here it is. > > A previous series attempted that: > https://lore.kernel.org/qemu-devel/[email protected]/, > but it was relying on (binary) symbol renaming, which is not a portable > solution. > Instead, this series approaches the problem from source code directly. > It requires more change, but it's cleaner IMHO. > > Series follows these steps: > > First, we make sure all helpers and definition are using HELPER() macro. A lot > of helpers were already defined this way, we just make sure it's exhaustive. > After that we don't have any 'helper_' left on any target code. This is a big > change touching the whole codebase, but it's a simple mechanical change. As > long > as it compiles and links, we know it's correct. > > Then, we introduce the prefix for target helpers. For this , we add a new > define > (from meson) that applies to all target related code. It could later be used > to > prefix other symbols also, that's why it's not named "TCG". > > Finally, we cleanup the previous manual helpers prefix that were added in > codebase. >
@Richard: does that series works for you? Since it's touching all targets, I would try to upstream this before the freeze on November 2 (ideally end of this week or early next week), to limit conflicts with all the people sending changes touching to any helper. Regards, Pierrick
