On 22/10/2026 21:55, Stian Halseth wrote:
Hi Mark,
On Thu, 2026-10-22 at 21:43 +0100, Mark Cave-Ayland wrote:
Please can we match the existing style in translate.c and remove the
indent here?
Noted for v4.
+ TCGv_i64 dst, src1, src2;
+
+ if (!avail_CRYPTO(dc)) {
+ return false;
+ }
+ if (gen_trap_ifnofpu(dc)) {
+ return true;
+ }
Question: is it possible for a 64-bit CPU not to have a FPU? Even
more so, one with
the crypto extensions present? I wonder if gen_trap_ifnofpu() isn't
needed here.
Not to my knowledge, but the gen_trap_ifnofpu() is checking if FPU is
enabled, not if it's present. Every sparc64 CPU has an FPU, but it can
be switched off. It's mentioned in the OSA 2011 spec.
(goes and looks)
Yes, you're right. I did wonder if the FPU registers were simply being used for
storage (as opposed to carrying out the instructions), however OSA 2011 indicates
that these instructions can throw an fp_disabled trap which suggests otherwise.
So it looks like this is correct.
ATB,
Mark.
