Missing review: 1 (new), 2 (rewrite)

v3:
- Add STR_ARRAY_ELEM_OR_NULL() suggested by Pierrick

v2:
- Addressed Pierrick suggestions
- No change addressed wrt logging-prefix (patch 2) because
  not needed so far.

Add qemu_excp_name() to resolve QEMU internal exception
values.

Add a common CPUClass::exception_name() callback so the
generic exception logger can resolve architecture-specific
exception values to human-readable names.

Re-use existing methods (expose prototype or refactor) when
available otherwise implement new ones (AVR, X86, MicroBlaze,
S390x, TriCore and Xtensa).

This series is the base for consolidating exception management
in accel/tcg/ (more series to be posted on top).

Philippe Mathieu-Daudé (31):
  qemu/osdep: Document ARRAY_SIZE() macro rejects pointers
  util/cutils: Add STR_ARRAY_ELEM_OR_NULL() for string table lookups
  cpus: Add helper to log raised exceptions with '-d int'
  cpus: Introduce CPUClass::exception_name() handler
  target/alpha: Register CPUClass::exception_name() handler
  target/alpha: Use a static table in alpha_exception_name()
  target/arm: Register CPUClass::exception_name() handler
  target/avr: Implement and register CPUClass::exception_name()
  target/hexagon: Register CPUClass::exception_name() handler
  target/hppa: Register CPUClass::exception_name() handler
  target/i386: Replace magic value by proper EXCP0E_PAGE definition
  target/i386: Implement and register CPUClass::exception_name()
  target/loongarch: Register CPUClass::exception_name() handler
  target/m68k: Register CPUClass::exception_name() handler
  target/m68k: Use a static table in m68k_exception_name()
  target/microblaze: Implement and register CPUClass::exception_name()
  target/mips: Remove EXCP_LAST, use ARRAY_SIZE(excp_names)
  target/mips: Register CPUClass::exception_name() handler
  target/or1k: Register CPUClass::exception_name() handler
  target/ppc: Name the EBB exceptions
  target/ppc: Use a static table in powerpc_excp_name()
  target/ppc: Register CPUClass::exception_name() handler
  target/riscv: Register CPUClass::exception_name() handler
  target/rx: Unify BRK and INT trap handling
  target/rx: Register CPUClass::exception_name() handler
  target/s390x: Implement and register CPUClass::exception_name()
  target/sh4: Register CPUClass::exception_name() handler
  target/sh4: Use a static table in sh4_exception_name()
  target/sparc: Remove always-defined DEBUG_PCALL
  target/sparc: Register CPUClass::exception_name() handler
  target/xtensa: Implement and register CPUClass::exception_name()

Yonggang Luo (2):
  target/rx: Define exception vector constants
  target/sh4: Define exception vector constants

 include/hw/core/cpu.h          |   2 +
 include/qemu/cutils.h          |  17 ++++
 include/qemu/osdep.h           |   9 ++
 target/alpha/cpu.h             |   1 +
 target/arm/cpu.h               |   4 +-
 target/avr/cpu.h               |   2 +
 target/hexagon/cpu_bits.h      |   2 +
 target/hppa/cpu.h              |   2 +
 target/i386/cpu.h              |   2 +
 target/loongarch/internals.h   |   2 +
 target/m68k/cpu.h              |   2 +
 target/microblaze/cpu.h        |   2 +
 target/mips/cpu.h              |   4 +-
 target/mips/tcg/tcg-internal.h |   2 -
 target/or1k/cpu.h              |   2 +
 target/ppc/cpu.h               |   2 +
 target/riscv/cpu.h             |   1 +
 target/rx/cpu.h                |  14 +++
 target/rx/helper.h             |   3 +-
 target/s390x/cpu.h             |   2 +
 target/sh4/cpu.h               |  22 +++++
 target/sparc/cpu.h             |   1 +
 target/xtensa/cpu.h            |   2 +
 accel/tcg/cpu-exec-common.c    |  36 ++++++++
 target/alpha/cpu.c             |   1 +
 target/alpha/helper.c          |  57 +++++-------
 target/arm/cpu.c               |   1 +
 target/arm/helper.c            |  77 ++++++++--------
 target/avr/cpu.c               |  17 ++++
 target/hexagon/cpu.c           |  35 ++++++++
 target/hexagon/hexswi.c        |  30 +------
 target/hppa/cpu.c              |  42 +++++++++
 target/hppa/int_helper.c       |  48 +---------
 target/i386/cpu.c              |  30 +++++++
 target/i386/tcg/excp_helper.c  |   7 +-
 target/i386/tcg/seg_helper.c   |  11 ++-
 target/loongarch/cpu.c         |  38 ++++++++
 target/loongarch/tcg/tcg_cpu.c |  41 ---------
 target/m68k/cpu.c              |   1 +
 target/m68k/op_helper.c        | 159 ++++++++++++---------------------
 target/microblaze/cpu.c        |  15 ++++
 target/mips/cpu.c              |   1 +
 target/mips/tcg/exception.c    |  10 +--
 target/or1k/cpu.c              |   1 +
 target/or1k/exception.c        |  22 +++++
 target/or1k/interrupt.c        |  19 +---
 target/ppc/cpu_init.c          |   1 +
 target/ppc/excp_helper.c       | 140 +++++++++++++++--------------
 target/riscv/cpu.c             |  20 ++---
 target/riscv/tcg/op_helper.c   |   2 +-
 target/rx/cpu.c                |   1 +
 target/rx/helper.c             |  62 +++++++------
 target/rx/op_helper.c          |  17 ++--
 target/rx/translate.c          |  23 +++--
 target/s390x/cpu.c             |   1 +
 target/s390x/interrupt.c       |  16 ++++
 target/s390x/tcg/excp_helper.c |   6 +-
 target/s390x/tcg/misc_helper.c |   3 +-
 target/sh4/cpu.c               |   1 +
 target/sh4/helper.c            | 109 ++++++++++------------
 target/sh4/op_helper.c         |  16 ++--
 target/sparc/cpu.c             |   1 +
 target/sparc/int32_helper.c    |  22 ++---
 target/sparc/int64_helper.c    |  42 ++++-----
 target/xtensa/cpu.c            |  24 +++++
 target/xtensa/exc_helper.c     |   3 +-
 util/cutils.c                  |   6 ++
 67 files changed, 750 insertions(+), 567 deletions(-)

-- 
2.55.0


Reply via email to