On Wed, Aug 1, 2012 at 11:31 PM, Stefan Hajnoczi <stefa...@gmail.com> wrote:
> On Tue, Jul 31, 2012 at 5:51 PM, Dong Xu Wang
> <wdon...@linux.vnet.ibm.com> wrote:
>> + if (backing_filename) {
>> + header.features |= ADD_COW_F_BACKING_FILE;
>> + header.backing_filename_offset = sizeof(header) + 16 * 2;
>
> It's not obvious what 16 * 2 is.
Okay we give meaningful constant later.
>
>> + ret = bdrv_pwrite(bs, sizeof(le_header) + 16,
>> + image_format ? image_format : "raw",
>> + image_format ? sizeof(image_format) : sizeof("raw"));
>
> sizeof(image_format)? I think this should be strlen(image_format).
Okay. thanks.
>
> Stefan
>
