Luiz Capitulino <lcapitul...@redhat.com> writes: > Quick summary first, long introduction afterwards. > >>From the rfc: > > o rebased on top of master > o dropped patch "qapi: qapi.py: allow the "'" character be escaped" > o split patch "qerror: drop qerror_abort()" into two patches > o fixed tcp_start_outgoing_migration() not to use QERR_ macros > o fixed qemu-ga to use the new error format > o dropped more unused stuff > o improved several changelogs > > Btw, please take a special look in patches 14/34, 15/34 and 16/34. > > > This series implements the 'Plan for error handling in QMP' as described > by Anthony in this email: > > http://lists.gnu.org/archive/html/qemu-devel/2012-07/msg03764.html > > Basically, this replaces almost all error classes by GenericError (the > exception are a few error classes used by libvirt) and drops the error > data memeber. This also adds a free form string to error_set(). > > On the wire, we go from: > > { "error": { "class": "DeviceNotRemovable", > "data": { "device": "virtio0" }, > "desc": "Device 'virtio0' is not removable" } } > > to: > > { "error": { "class": "GenericError", > "desc": "Device 'virtio0' is not removable" } } > > Internally, we go from: > > void error_set(Error **err, const char *fmt, ...); > > to: > > void error_set(Error **err, ErrorClass err_class, const char *fmt, ...);
Good stuff overall. Last but not least: [...] > 25 files changed, 284 insertions(+), 880 deletions(-)
