Replace sprintf("%02x) by equivalent qemu_hexdump_to_buffer()
helper and silent when using Apple clang 17.0.0:
../tests/qtest/libqtest.c:1522:9: warning: 'sprintf' is deprecated:
This function is provided for compatibility reasons only.
Due to security concerns inherent in the design of sprintf(3),
it is highly recommended that you use snprintf(3) instead.
[-Wdeprecated-declarations]
Signed-off-by: Philippe Mathieu-Daudé <[email protected]>
---
tests/qtest/libqtest.c | 6 +-----
1 file changed, 1 insertion(+), 5 deletions(-)
diff --git a/tests/qtest/libqtest.c b/tests/qtest/libqtest.c
index 7f66c1bbb3b6..b6b9f8fe161d 100644
--- a/tests/qtest/libqtest.c
+++ b/tests/qtest/libqtest.c
@@ -1509,7 +1509,6 @@ void qtest_bufread(QTestState *s, uint64_t addr, void
*data, size_t size)
void qtest_memwrite(QTestState *s, uint64_t addr, const void *data, size_t
size)
{
const uint8_t *ptr = data;
- size_t i;
char *enc;
if (!size) {
@@ -1517,10 +1516,7 @@ void qtest_memwrite(QTestState *s, uint64_t addr, const
void *data, size_t size)
}
enc = g_malloc(2 * size + 1);
-
- for (i = 0; i < size; i++) {
- sprintf(&enc[i * 2], "%02x", ptr[i]);
- }
+ qemu_hexdump_to_buffer(enc, 2 * size + 1, ptr, size);
qtest_sendf(s, "write 0x%" PRIx64 " 0x%zx 0x%s\n", addr, size, enc);
qtest_rsp(s);
--
2.55.0
