Hi, On Mon, 24 Sep 2007, Ivan Kalvachev wrote:
> 2007/9/24, Johannes Schindelin <[EMAIL PROTECTED]>: > > > On Mon, 24 Sep 2007, Ivan Kalvachev wrote: > > > > > I had a discussion with Johannes Schindelin over my patch, that I > > > thought is on the maillist, but apparently it wasn't. I'm > > > subscribed, so please don't send me mails directly, gmail web > > > interface could be quite misleading. > > > > > > So here is the third revision of my patch. Changes include: using > > > more structures instead of fixed byte locations. chs and nt_id. more > > > detailed comments, function name shortened and if(lba) moved to ?: > > > construct. > > > > Almost all my comments went unheeded. > > I believe that I've answered and addressed all your comments. Ooops. I think I mixed up your patch with the other patch for vvfat that floated around recently. (Probably because the patch was not inlined...) FWIW if we're talking about qemu_vvfat_mbr_v3.patch, I have no more gripes. Thanks, Dscho
