On 3 September 2012 19:58, Blue Swirl <blauwir...@gmail.com> wrote: > On Mon, Sep 3, 2012 at 12:03 AM, Peter Maydell <peter.mayd...@linaro.org> > wrote: >> On 3 September 2012 01:01, Peter Maydell <peter.mayd...@linaro.org> wrote: >> That's quite hard to cross-reference when the patch is this big. >> I think it would be helpful if you could split it up into patches >> touching smaller groups of helpers at once rather than having a >> single patch that does them all at once. > > For x86, Sparc and s390x I used the approach of splitting op_helper.c > to smaller files first. I didn't do it for ARM since > target-arm/op_helper.c is alread pretty small (<500 lines). It could > be split to saturating ops, condition code setting arithmetic ops and > misc ops, between 100 and 200 lines each. Would that be OK?
I don't want the *file* split, I'd just like to see this *patch* as 4 or 5 separate patches, not one big one. (Patch-splitting is a personal preference thing; I generally favour lots of little patches over big ones.) thanks -- PMM
