On Wed, 2007-10-10 at 21:38 -0600, Thayne Harbaugh wrote: > I appreciate the work that Jocelyn did to correct the types used > throughout linux-user/syscall.c. Along those same lines I am working on > several patches to eliminate some incorrect constructs that have crept > into syscall.c - some of which I have ignorantly propagated in previous > patches that I have submitted. > > I have noticed that many functions in syscall.c return a *host* errno > when a *target* errno should be return. At the same time, there are > several places in syscall.c:do_syscall() that immediately return an > errno rather than setting the return value and exiting through the > syscall return value reporting at the end of do_syscall(). > > This patch addresses both of those problems at once rather than touching > the exact same errno return lines twice in do_syscall(). It also > touches a few functions in linux-user/signal.c that are called from > do_syscall(). > > Please send comments - I have several more patches that will build on > this one as well as a few more patches that will fix other incorrect > constructs with target/host address handling. > > Thanks.
Hi, there are still a lot of problems hidden in syscalls.c and signal.c, as you noticed. Your patch seems OK to me and adding all those comments is imho really great. My only remark is a cosmetic one: I don't like too much hidding 'goto' in macros... -- J. Mayer <[EMAIL PROTECTED]> Never organized