On 09/18/12 17:01, Stefano Stabellini wrote: > On Tue, 18 Sep 2012, Gerd Hoffmann wrote: >> Stop reinventing the wheel. Use the pixman library for raster ops. > > I would separate the pixmap changes from this series: either we use > this library everywhere or nowhere. At the very least vnc could use it.
The secret long term plan is to use pixman everywhere, but that is certainly way to much for a single series anyway. I have patches in the queue to switch over spice to pixman (and remove pflib.[ch]). vnc and sdl are obviously candidates. Possibly device emulation too: vga textmode font rendering, cirrus 2d ops. But that is surely for another discussion as this would make pixman a hard dependency for qemu. > Also considering that you only support 32bpp in fbdev, I am not sure > whether it actually is that useful in this case: you don't really need > to handle any pixel format conversions, at most you need to handle > differences in linesizes. DisplaySurfaces can be 16bpp too. The limitation to 32bpp can go away, that is just a leftover from earlier revisions, 15+16 bpp should just work too. Also with the full series applied we let pixman do alot more than just pixel copying: scaling, dirty area tracking, alpha bleeding. cheers, Gerd
