Re: [Qemu-devel] [PATCH v4 3/4] Fix address handling in inet_nonblocking_connect

[Orit Wasserman]

On 09/24/2012 12:10 PM, Michael S. Tsirkin wrote:
> On Sun, Sep 23, 2012 at 04:49:06PM +0200, Orit Wasserman wrote:
>> diff --git a/qemu_socket.h b/qemu_socket.h
>> index 3247fb7..da93509 100644
>> --- a/qemu_socket.h
>> +++ b/qemu_socket.h
>> @@ -38,20 +38,31 @@ void socket_set_block(int fd);
>>  void socket_set_nonblock(int fd);
>>  int send_all(int fd, const void *buf, int len1);
>>  
>> +/* callback function for nonblocking connect
>> + * vaild fd on success, negative error code on failure
> 
> typo
> 
>> + */
>> +typedef void ConnectHandler(int fd, void *opaque);
> 
> Can we rename this NonBlockingConnectHandler?
Of course.
> 
>> +
>>  /* New, ipv6-ready socket helper functions, see qemu-sockets.c */
> 
> BTW let's kill this comment.
>