On 09/25/2012 03:13 PM, Eric Blake wrote: > On 09/25/2012 10:29 AM, Jeff Cody wrote: >> This is a simple helper function, that will return the base image >> of a given image chain. >> >> Signed-off-by: Jeff Cody <jc...@redhat.com> >> --- >> block.c | 16 ++++++++++++++++ >> block.h | 1 + >> 2 files changed, 17 insertions(+) > > Bikeshed question: Any reason patch 1/7 adds two helper functions, and > patch 4/7 adds a third? Perhaps it would be worth squashing all three > into one commit, or else having three commits, one per helper? But > there's no point in repainting things now, so: > > Reviewed-by: Eric Blake <ebl...@redhat.com> >
The reasoning was the helper functions in 1/7 were to support block commit (patch 2/7), and the helper function in 4/7 was to support the block commit QMP command (patch 5/7), so it seemed logical to split them.
