Il 27/09/2012 22:31, Jeff Cody ha scritto: > > block_job_completed(): cleans up when a job is done
It also raises a BLOCK_JOB_COMPLETED event. > block_job_complete(): requests that a block job be completed > > How about renaming both of them, respectively, to: > > block_job_cleanup(): cleans up when a job is done > block_job_request_completion(): requests that a block job be completed > > I think that would remove any ambiguity. I'll keep this patch for now, since it doesn't introduce any ambiguity yet. I could rename block_job_complete to block_job_request_completion as you suggested, but it would be inconsistent with the QMP command block-job-complete, so there are downsides as well. Paolo
