On 2012-10-04 16:43, Igor Mammedov wrote:
> + /* XXX: mapping more APICs at the same memory location */
> + if (apic_mapped == 0) {
> + /* NOTE: the APIC is directly connected to the CPU - it is not
> + on the global memory bus. */
> + /* XXX: what if the base changes? */
> + sysbus_mmio_map(sysbus_from_qdev(env->apic_state), 0, MSI_ADDR_BASE);
> + apic_mapped = 1;
> + }
> +
> + return;
Unneeded return.
Jan
> +#endif
> +}
> +
> void x86_cpu_realize(Object *obj, Error **errp)
> {
> X86CPU *cpu = X86_CPU(obj);
> @@ -1878,6 +1934,8 @@ void x86_cpu_realize(Object *obj, Error **errp)
> qemu_register_reset(x86_cpu_machine_reset_cb, cpu);
> #endif
>
> + x86_cpu_apic_init(cpu, errp);
> +
> mce_init(cpu);
> qemu_init_vcpu(&cpu->env);
> cpu_reset(CPU(cpu));
>
--
Siemens AG, Corporate Technology, CT RTC ITP SDP-DE
Corporate Competence Center Embedded Linux
