On 11/01/2012 03:06 PM, Anthony Liguori wrote:
> I don't have a kernel with the necessary syscalls so this is completely
> untested.
>
> Cc: "M. Mohan Kumar" <mo...@in.ibm.com>
> Cc: Gerhard Wiesinger <li...@wiesinger.com>
> Reported-by: Gerhard Wiesinger <li...@wiesinger.com>
> Signed-off-by: Anthony Liguori <aligu...@us.ibm.com>
> ---
> fsdev/virtfs-proxy-helper.c | 8 ++++++--
> 1 file changed, 6 insertions(+), 2 deletions(-)
>
> diff --git a/fsdev/virtfs-proxy-helper.c b/fsdev/virtfs-proxy-helper.c
> index f9a8270..bc50e3e3 100644
> --- a/fsdev/virtfs-proxy-helper.c
> +++ b/fsdev/virtfs-proxy-helper.c
> @@ -286,12 +286,16 @@ static int setfsugid(int uid, int gid)
> * We still need DAC_OVERRIDE because we don't change
> * supplementary group ids, and hence may be subjected DAC rules
> */
> + int ret;
> cap_value_t cap_list[] = {
> CAP_DAC_OVERRIDE,
> };
>
> - setfsgid(gid);
> - setfsuid(uid);
> + ret = setfsgid(gid);
> + g_assert(ret != -1);This has been reported several times now, with several different patches proposed. Can we get consensus on which one to use? https://lists.gnu.org/archive/html/qemu-devel/2012-10/msg02013.html -- Eric Blake ebl...@redhat.com +1-919-301-3266 Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
