Il 15/11/2012 17:13, ronnie sahlberg ha scritto: > On Thu, Nov 15, 2012 at 7:54 AM, Paolo Bonzini <pbonz...@redhat.com> wrote: >> Il 15/11/2012 15:57, ronnie sahlberg ha scritto: >>> I dont know if we should switch to use synchronous code here. >>> It is much nicer if all code is async. >> >> bdrv_open is generally synchronous, so I think Peter's patch is ok. > > I was thinking about the case where you disconnect/reconnect a device > at runtime. Like swapping the medium in a CDROM. > If bdrv_open() is synchronous and blocks for a long time, would that > not impact the rest of QEMU?
Yes, it's not optimal, but VCPUs would still run until they request I/O. But usually iscsi devices should be non-removable, no? That leaves hotplug as the only problematic case. Paolo > > Otherwise: > Acked-by: ronniesahlb...@gmail.com > >> >> Paolo >> >>> Is it possible to add a timeout instead that would break out if the >>> connect/login has not completed within a certain amount of time? >>
