Re: [Qemu-devel] [kvmarm] [RFC v4 8/8] oslib-posix: Align to permit transparent hugepages on ARM Linux

[Christoffer Dall]

On Tue, Nov 20, 2012 at 8:54 AM, Alexander Graf <ag...@suse.de> wrote:
> On 11/20/2012 02:31 PM, Peter Maydell wrote:
>>
>> ARM Linux (like x86-64 Linux) can use transparent hugepages for
>> KVM if memory blocks are 2MiB aligned; set QEMU_VMALLOC_ALIGN
>> accordingly.
>>
>> Signed-off-by: Peter Maydell<peter.mayd...@linaro.org>
>> ---
>>   oslib-posix.c |    2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/oslib-posix.c b/oslib-posix.c
>> index 9db9c3d..d25b52a 100644
>> --- a/oslib-posix.c
>> +++ b/oslib-posix.c
>> @@ -35,7 +35,7 @@
>>   extern int daemon(int, int);
>>   #endif
>>
>> -#if defined(__linux__)&&  defined(__x86_64__)
>> +#if defined(__linux__)&&  (defined(__x86_64__) || defined(__arm__))
>
>
> Why not just drop the arch specific bit?
>
>
other archs have other alignment requirements, iirc.