On Sun, Dec 02, 2012 at 03:57:17AM +0100, Andreas Färber wrote: >Hello, > >Some review comments for SysBus EHCI were ignored in favor of merging into 1.3. >As requested by Gerd, this now follows up with the cleanups I had requested >from Peter C. Apart from using the new-style QOM casts it also achieves some >deduplification. It then goes on to implement the suggested more slim way to >have different capsbase and opregbase values; the alternative would be to >create a new struct SysBusEHCIInfo for declarative initialization. Given that >there are only few models for now, the imperative approach allows for more >flexibility such as inheritence when, e.g., an Exynos 5 model varies only >slightly from Exynos 4. > >Appended is Liming's patch to add an EHCI device to Exynos 4 as well as a >new patch of mine to prepare a Tegra 2 EHCI device (cf. my tegra branch) to
BTW, where can I find your tegra branch? >show how this works out. > >Regards, >Andreas > >Changes from Liming Wang's patchset: >* Introduce abstract sysbus-ehci-usb and pci-ehci-usb types It's good to implement these two abstract types, so that it's easy to add sysbus-ehci-usb sub types. >* Move class_init / instance_init to base type as far as possible >* Use TYPE_* constant for instantiating exynos4210 EHCI >* Added my tegra2 SysBus EHCI device to the mix > >Cc: Gerd Hoffmann <kra...@redhat.com> >Cc: Peter A. G. Crosthwaite <peter.crosthwa...@xilinx.com> >Cc: Peter Maydell <peter.mayd...@linaro.org> >Cc: Igor Mitsyanko <i.mitsya...@samsung.com> >Cc: Liming Wang <walimis...@gmail.com> >Cc: Vincent Palatin <vpala...@chromium.org> > >Andreas Färber (4): > usb/ehci: Clean up SysBus and PCI EHCI split > usb/ehci: Move capsbase and opregbase into SysBus EHCI class > usb/ehci: Add SysBus EHCI device for Exynos4210 > usb/ehci: Add Tegra2 SysBus EHCI device > >Liming Wang (1): > exynos4210: Add EHCI support The test is OK for exynos4210 ehci. Regards, Liming Wang > > hw/exynos4210.c | 7 +++++ > hw/exynos4210_gic.c | 2 +- > hw/usb/hcd-ehci-pci.c | 37 ++++++++++++++++------ > hw/usb/hcd-ehci-sysbus.c | 76 ++++++++++++++++++++++++++++++++++++++++++---- > hw/usb/hcd-ehci.h | 2 ++ > 5 Dateien geändert, 108 Zeilen hinzugefügt(+), 16 Zeilen entfernt(-) > >-- >1.7.10.4 >
