On Thu, Dec 20, 2012 at 03:37:58PM +0100, Paolo Bonzini wrote: > Il 20/12/2012 15:20, Michael S. Tsirkin ha scritto: > > diff --git a/hw/vhost_net_stub.c b/hw/vhost_net_stub.c > > new file mode 100644 > > index 0000000..387b578 > > --- /dev/null > > +++ b/hw/vhost_net_stub.c > > @@ -0,0 +1 @@ > > +#include "vhost_net.c" > > Nice. As a follow-up, can you perhaps split the vhost_net.c file in two > following the model of other *-stub.c files? > > Paolo
Still thinking about this - keeping it all in a single file makes it easier to change interfaces, OTOH making stub separate means less platforms need to be rebuilt when only implementation changes.