Am 10.01.2013 um 13:09 schrieb Paolo Bonzini <pbonz...@redhat.com>: > Il 10/01/2013 12:57, Peter Lieven ha scritto: >> Paolo, if you agree I would resubmit the patch (using your description). > > Using the description is fine. Also at least remove the memset. > >> I would not directly collapse the code to as its not obvious what >> bdrv_exceed_io_limits(bs, 0, 0, NULL); >> is doing. Maybe this could be done in a later patch. > > You're right that it's not obvious. > > But perhaps we do not need to start a slice at all when iolimits are > set. That is, do > > bs->slice_start = bs->slice_end = bs->slice_time = 0; > > or perhaps even nothing at all since bdrv_io_limits_disable should have > written those exact values.
Or it was set when the BlockDriverState was initialized. I am not familiar enough with the io limits code to decide if not starting a slice is also correct. Peter > > Paolo
