On Wed, 23 Jan 2013 11:30:23 +0800
Lei Li <li...@linux.vnet.ibm.com> wrote:
> On 01/23/2013 12:27 AM, Luiz Capitulino wrote:
> > On Tue, 22 Jan 2013 16:12:51 +0800
> > Lei Li <li...@linux.vnet.ibm.com> wrote:
> >
> >> Signed-off-by: Lei Li <li...@linux.vnet.ibm.com>
> >> ---
> >> hmp-commands.hx | 16 ++++++++++++++++
> >> hmp.c | 13 +++++++++++++
> >> hmp.h | 1 +
> >> qapi-schema.json | 41 +++++++++++++++++++++++++++++++++++++++++
> >> qemu-char.c | 48 ++++++++++++++++++++++++++++++++++++++++++++++++
> >> qmp-commands.hx | 34 ++++++++++++++++++++++++++++++++++
> >> 6 files changed, 153 insertions(+), 0 deletions(-)
> >>
> >> diff --git a/hmp-commands.hx b/hmp-commands.hx
> >> index 0934b9b..e546c76 100644
> >> --- a/hmp-commands.hx
> >> +++ b/hmp-commands.hx
> >> @@ -837,6 +837,22 @@ STEXI
> >> @item nmi @var{cpu}
> >> @findex nmi
> >> Inject an NMI on the given CPU (x86 only).
> >> +
> >> +ETEXI
> >> +
> >> + {
> >> + .name = "memchar_write",
> >> + .args_type = "chardev:s,data:s",
> >> + .params = "chardev data",
> > This is missing .help. Please look at the other entries for examples.
>
> Hmm, I did add .help here before version 5, and I get rid of them
> based on your comments "Help doesn't make sense for HMP."...
Did I really say that? The help text makes sense _only_ for HMP.
I may have quoted the wrong .hx file. If I did that I'm sorry, but it's
also just a matter of checking other entries in the file to see if
yours is correct.
